fix: don't treat bad sdist metadata as fatal error#788
Merged
mergify[bot] merged 1 commit intopython-wheel-build:mainfrom Sep 25, 2025
Merged
fix: don't treat bad sdist metadata as fatal error#788mergify[bot] merged 1 commit intopython-wheel-build:mainfrom
mergify[bot] merged 1 commit intopython-wheel-build:mainfrom
Conversation
`default_get_install_dependencies_of_sdist` no longer treats bad sdist metadata as a fatal error. The function now logs a non-fatal error message to inform the user of potential issues. Fromager stub metadata is no longer validated at all. It likely contains a wrong version number. Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
sdist-metadata-validation
branch
from
ddba77d to
d2a5c8b
Compare
LalatenduMohanty
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default_get_install_dependencies_of_sdistno longer treats bad sdist metadata as a fatal error. The function now logs a non-fatal error message to inform the user of potential issues.Fromager stub metadata is no longer validated at all. It likely contains a wrong version number.