fix: revert broken features#787
Closed
dhellmann wants to merge 4 commits intopython-wheel-build:mainfrom
Closed
Conversation
…ommand" This reverts commit 0664d8d. This change introduces new runtime requirements that we can't absorb downstream.
…ist" This reverts commit bb9ee8e. We have to revert the feature addition that this depends on.
This reverts commit 86a39db. Validating the name and version of the packages happens too early, so packages with plugins that override those settings via the metadata hook end up reporting the wrong versions.
Member
Author
|
It looks like we've landed fixes and don't need this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the feature that validates the name and version of the
packages because it happens too early, so packages with plugins
that override those settings via the metadata hook end up reporting
the wrong versions.
Revert the feature that resolves requirements in the linter because
it introduces new runtime dependencies that we can't absorb downstream.
Both of these changes are breaking different jobs downstream, and
we don't have a release of fromager that includes #786 but does
not include the changes reverted here.