Skip to content

Make list_files() traversal deterministic #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pquentin merged 1 commit into from
Jul 31, 2026
Merged

Make list_files() traversal deterministic #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/test_unasync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
def list_files(startpath):
output = ""
for root, dirs, files in os.walk(startpath):
dirs.sort()

@pquentin pquentin Jul 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to read the docs to convince myself that this had any effect with the default topdown=True. Thanks, TIL.

files.sort()
level = root.replace(startpath, "").count(os.sep)
indent = " " * 4 * (level)
output += f"{indent}{os.path.basename(root)}/"
Expand Down
Loading