Skip to content

Run pyroma in tox -e lint instead of pytest#9670

Merged
radarhere merged 2 commits into
python-pillow:mainfrom
hugovk:tox-pyroma
Jun 15, 2026
Merged

Run pyroma in tox -e lint instead of pytest#9670
radarhere merged 2 commits into
python-pillow:mainfrom
hugovk:tox-pyroma

Conversation

@hugovk

@hugovk hugovk commented Jun 12, 2026

Copy link
Copy Markdown
Member

Fixes #9668.
Replaces and closes #9669.

Put pyroma in pre-commit. It can take a few seconds to run, so put it in the manual stage, so it's not run by default.

  • A benefit of putting it in pre-commit is it is pinned, so won't suddenly fail when a new version comes out. We also get automated updates.

Run it in tox -e lint, which does the regular pre-commit, and is run on the CI.

Pyroma itself will run check-manifest (when check-manifest is installed), so don't run it twice in tox -e lint or make release-test.

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
@radarhere radarhere merged commit d303f28 into python-pillow:main Jun 15, 2026
108 of 113 checks passed
@hugovk hugovk deleted the tox-pyroma branch June 15, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Pyroma test to be non-runtime

3 participants