feat: Add Datadog schema hooks - #701
Open
lannuttia wants to merge 3 commits into
Open
Conversation
- Add check-datadog-continuous-testing hook for datadog-ci.(json|yml|yaml) - Add check-datadog-service-definition hook for service.datadog.(json|yml|yaml) - Add check-datadog-software-catalog hook for entity.datadog.(json|yml|yaml) All three schemas are from DataDog/schema repository under Apache 2.0 license. Schemas support remote $ref dependencies which are resolved automatically.
sirosen
reviewed
Aug 8, 2026
sirosen
left a comment
sirosen
left a comment
Member
There was a problem hiding this comment.
This seems like a perfectly good addition; can we add a bit of testing to make sure that the hooks are, and stay, in good working order?
You can see some tests for hook patterns here, and there's a suite of tests here which automatically check schemas against examples in tests/example-files/hooks/.
I also had a minor note for the changelog.
| ``check-datadog-service-definition``, and ``check-datadog-software-catalog``. | ||
| Thanks :user:`lannuttia`! (:issue:`702`, :pr:`701`) | ||
|
|
||
| .. vendor-insert-here |
Member
There was a problem hiding this comment.
Minor, but let's put this note down below this comment; the vendoring script uses the comment to insert the Update vendored schemas: ... entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Datadog schema hooks from https://github.com/DataDog/schema.
Closes #702.
This PR adds three new pre-commit hooks for validating Datadog configuration files:
check-datadog-continuous-testing- Validates Datadog Continuous Testing configuration filescheck-datadog-service-definition- Validates Datadog Service Definition filescheck-datadog-software-catalog- Validates Datadog Software Catalog entity filesAll schemas are sourced from the official DataDog/schema repository on GitHub.