fix: decode percent-encoded unreserved chars before resolving dot segments in normalize#195
Open
gaoflow wants to merge 1 commit into
Open
Conversation
…ments in normalize RFC 3986 Section 6.2.2.2 specifies that percent-encoded unreserved characters should be decoded before applying other normalizations, including dot-segment resolution. The previous order (resolve-then-decode) meant that %2e%2e was not recognized as ".." during path normalization, producing incorrect results like http://example.com/../foo instead of http://example.com/foo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URL.normalize()resolves dot segments (.and..) before decoding percent-encoded unreserved characters. Per RFC 3986 Section 6.2.2.2, this order is incorrect -- unreserved characters should be decoded first.For example,
%2eis the percent-encoded form of.(a period is an unreserved character). The path/%2e%2e/fooshould be normalized to/foo, but currently it normalizes to/../foo.Before
After
Test plan
test_normalize_percent_encoded_dot_segmentscovering three cases:%2e%2e(double-dot parent reference)%2e(single-dot current directory reference)foo/%2e%2e/bar(encoded parent traversal in middle of path)This PR was written under human direction (gaoflow).