Skip to content

Fix the version number#224

Merged
sethmlarson merged 1 commit intopython-hyper:mainfrom
ngoldbaum:fix-version-number
Mar 5, 2026
Merged

Fix the version number#224
sethmlarson merged 1 commit intopython-hyper:mainfrom
ngoldbaum:fix-version-number

Conversation

@ngoldbaum
Copy link
Contributor

This should fix the test failure seen on main:

>           assert brotlicffi.__version__.startswith(
                "%s.%s.%s." % (
                    brotli_versions["MAJOR"],
                    brotli_versions["MINOR"],
                    brotli_versions["PATCH"]
                )
            )
E           AssertionError: assert False
E            +  where False = <built-in method startswith of str object at 0x00000152CB7C7AF0>(('%s.%s.%s.' % ('1', '2', '0')))
E            +    where <built-in method startswith of str object at 0x00000152CB7C7AF0> = '1.2.1.0'.startswith
E            +      where '1.2.1.0' = brotlicffi.__version__

I already deleted the v1.2.1.0 tag.

Let's wait to merge this until CI passes.

@ngoldbaum
Copy link
Contributor Author

OK, now we should be ready @sethmlarson.

@sethmlarson sethmlarson merged commit 3fd4d20 into python-hyper:main Mar 5, 2026
30 checks passed
@sethmlarson
Copy link
Member

@ngoldbaum Okay, you can push a tag now for 1.2.0.1.

@ngoldbaum
Copy link
Contributor Author

Tag is pushed and the deploy step is ready.

I had to restart the mac 3.14t testing job because the shared concurrency test failed. See https://github.com/python-hyper/brotlicffi/actions/runs/22731598528/job/65929098936.

I’m planning to look at the closer but I think it’s not worth holding up the release over given that free-threaded support is brand new. If you disagree, let me know and I’ll up the urgency on looking at that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants