Merged
Conversation
Contributor
Author
|
OK, now we should be ready @sethmlarson. |
sethmlarson
approved these changes
Mar 5, 2026
Member
|
@ngoldbaum Okay, you can push a tag now for 1.2.0.1. |
Contributor
Author
|
Tag is pushed and the deploy step is ready. I had to restart the mac 3.14t testing job because the shared concurrency test failed. See https://github.com/python-hyper/brotlicffi/actions/runs/22731598528/job/65929098936. I’m planning to look at the closer but I think it’s not worth holding up the release over given that free-threaded support is brand new. If you disagree, let me know and I’ll up the urgency on looking at that test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the test failure seen on
main:I already deleted the
v1.2.1.0tag.Let's wait to merge this until CI passes.