Skip to content
This repository was archived by the owner on Mar 14, 2021. It is now read-only.
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
4c99800
first commit
delterr Mar 23, 2018
7ed1c2a
Added temp code for bot.get
delterr Mar 23, 2018
020deb7
Updated pipfile/pipfile.lock
delterr Mar 23, 2018
968c748
adding temporary code that fetches wiki page on snakes
delterr Mar 23, 2018
3011280
added the fetch code to getsnek
delterr Mar 23, 2018
1f6f877
added .idea/ to .gitignore
Mar 23, 2018
fb31d2b
added get_snek() call to get()
Mar 23, 2018
c8d42d3
replaced message.channel with ctx
Mar 23, 2018
b8fdfd7
Removed snake find
delterr Mar 23, 2018
810ebad
Fetching data
delterr Mar 23, 2018
95443bb
Merge remote-tracking branch 'origin/master'
delterr Mar 23, 2018
367a400
Merge pull request #1 from discord-python/master
delterr Mar 24, 2018
502abb9
Added random snake
delterr Mar 24, 2018
4e2c293
Merge branch 'master' of https://github.com/Hasan-Ahmad/code-jam-1
delterr Mar 24, 2018
ac46387
Merge remote-tracking branch 'origin/master'
delterr Mar 24, 2018
57d1394
wiki site now a member variable
Mar 24, 2018
2bcae58
fixed post-merge issues
Mar 24, 2018
3c7367b
combined imports
Mar 24, 2018
b1376c8
added 'wikipedia' to imports
Mar 24, 2018
6734b50
replace URL with string for wiki
Mar 24, 2018
090f14f
Merge branch 'master' of https://github.com/Hasan-Ahmad/code-jam-1
delterr Mar 24, 2018
b5c5402
Merge remote-tracking branch 'origin/master'
delterr Mar 24, 2018
fcaecfb
Added python message
delterr Mar 24, 2018
71bde19
Merge pull request #2 from discord-python/master
delterr Mar 24, 2018
018e523
Merge branch 'master' of https://github.com/Hasan-Ahmad/code-jam-1
delterr Mar 24, 2018
59fa010
Merge remote-tracking branch 'origin/master'
delterr Mar 24, 2018
8e5cf70
test
delterr Mar 24, 2018
e36ae9e
PEP 8 fix
delterr Mar 24, 2018
9f075e9
Updated snake name fetch
delterr Mar 24, 2018
e0db09f
Merge remote-tracking branch 'origin/master'
Mar 24, 2018
28f1154
Adding embeds
delterr Mar 24, 2018
2f16d10
Merge remote-tracking branch 'origin/master'
Mar 24, 2018
b63381e
removed some gentle hard-coding
Mar 24, 2018
33bddfc
updating embed
delterr Mar 24, 2018
a2eddb4
Merge remote-tracking branch 'origin/master'
delterr Mar 24, 2018
34864b5
begin working on snake
Mar 24, 2018
2ff9b48
on_message now appends full object
Mar 24, 2018
5a6932e
working message logger
Mar 24, 2018
6f04e37
snake maybe possible probably not?
Mar 24, 2018
ff7469d
Merge remote-tracking branch 'origin/master'
delterr Mar 25, 2018
2d5f3b6
Merge branch 'master' of https://github.com/Hasan-Ahmad/code-jam-1
delterr Mar 25, 2018
4765a23
update snakes.py
delterr Mar 25, 2018
aa5b3ed
update nakes.py
delterr Mar 25, 2018
9bbeb30
snake no tail complete
Mar 25, 2018
f448a4e
DNP: bug with logging
Mar 25, 2018
36933e4
apples and framework for tail
Mar 25, 2018
417d7a7
added lxml to pipfile
Mar 25, 2018
6a804bd
tuples/tail
Mar 25, 2018
ac7c08a
Merge branch 'master' of https://github.com/Hasan-Ahmad/code-jam-1
delterr Mar 25, 2018
996edba
Merge branch 'master' of https://github.com/Hasan-Ahmad/code-jam-1
delterr Mar 25, 2018
40efcaa
removed unused imports
Mar 25, 2018
56da195
Changed how much info is scraped from the table
delterr Mar 25, 2018
0c1c026
PEP8 fix
delterr Mar 25, 2018
989e5d1
you can die now:
Mar 25, 2018
adff2e6
Snake complete
Mar 25, 2018
4399dcb
PEP8 fix, typo fix, removed unnecessary comments
delterr Mar 25, 2018
8904bce
emogis
Mar 25, 2018
e0bf1cc
petty rage push
Mar 25, 2018
f03b98f
done stuff to changes
Mar 25, 2018
127051f
main loop breaks now all use Running
Mar 25, 2018
41b2ba4
added break to user inputs
Mar 25, 2018
a620972
removed black line
Mar 25, 2018
f811720
added blank line
Mar 25, 2018
5987a8a
re-ordered some imports
Mar 25, 2018
804af0a
re-ordered some imports
Mar 25, 2018
f87d75e
re-ordered some imports
Mar 25, 2018
42eae45
re-ordered some imports
Mar 25, 2018
0c83aaf
Update import order
Mar 25, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
Binary file not shown.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ __pycache__/
# Distribution / packaging
.Python
env/
.env
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these both already in the gitignore?

build/
develop-eggs/
dist/
Expand Down
3 changes: 3 additions & 0 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ name = "pypi"
aiodns = "*"
aiohttp = "<2.3.0,>=2.0.0"
websockets = ">=4.0,<5.0"
"beautifulsoup4" = "*"
requests-html = "*"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've edited this file by hand. This is bad practise, but at least you've updated the lockfile as well.

Please be careful about using requests - it's not asynchronous.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am 100% sure that I did not update the Pipfile by hand. I used pipenv install requests-html

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Either way, we've made a statement about the wikipedia module on Discord, and the same applies to Requests. Requests does not support asyncio, and you're going to want to avoid any solution that doesn't.

wikipedia = "*"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're not using this, you should pipenv uninstall it.


[dev-packages]
"flake8" = "*"
Expand Down
139 changes: 138 additions & 1 deletion Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion bot/cogs/snakes.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# coding=utf-8
import logging
from typing import Any, Dict

import wikipedia
from discord.ext.commands import AutoShardedBot, Context, command


log = logging.getLogger(__name__)


Expand All @@ -28,6 +29,11 @@ async def get_snek(self, name: str = None) -> Dict[str, Any]:
:param name: Optional, the name of the snake to get information for - omit for a random snake
:return: A dict containing information on a snake
"""
snake_summary = wikipedia.sumamry(self.name)





@command()
async def get(self, ctx: Context, name: str = None):
Expand All @@ -40,6 +46,8 @@ async def get(self, ctx: Context, name: str = None):
:param ctx: Context object passed from discord.py
:param name: Optional, the name of the snake to get information for - omit for a random snake
"""
await ctx.send("hello")


# Any additional commands can be placed here. Be creative, but keep it to a reasonable amount!

Expand Down