flood.py: clean up every channel an image-spam burst touched - #14
Merged
Conversation
attachment_check's burst path only deleted the one message that happened to cross the 2-channel threshold, leaving earlier copies of the same spam images up in whichever channels they were posted to first - a compromised account spraying images across channels could beat detection (and the resulting mute) to several of them before getting caught. image_authors now tracks the actual per-channel message (not just a timestamp), so once a burst is confirmed, every tracked channel gets its message deleted and the "cuenta comprometida" warning posted - not just the triggering one. Deletion tolerates a message already being gone (e.g. removed manually first) rather than crashing, and still warns that channel regardless. The mod-thread alert title now also reports how many channels were affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attachment_check's burst path only deleted the one message that happened to cross the 2-channel threshold, leaving earlier copies of the same spam images up in whichever channels they were posted to first - a compromised account spraying images across channels could beat detection (and the resulting mute) to several of them before getting caught.
image_authors now tracks the actual per-channel message (not just a timestamp), so once a burst is confirmed, every tracked channel gets its message deleted and the "cuenta comprometida" warning posted - not just the triggering one. Deletion tolerates a message already being gone (e.g. removed manually first) rather than crashing, and still warns that channel regardless. The mod-thread alert title now also reports how many channels were affected.