Fix intermediate __setattr__ handling in mixed inheritance chains#1567
Open
sahvx655-wq wants to merge 4 commits into
Open
Fix intermediate __setattr__ handling in mixed inheritance chains#1567sahvx655-wq wants to merge 4 commits into
sahvx655-wq wants to merge 4 commits into
Conversation
…ixed attrs and plain Python classes
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a correctness issue in attrs where setattr could be incorrectly overridden when using intermediate base classes that define a custom setattr.
Previously, only immediate base classes were checked, which caused custom setattr implementations in deeper inheritance hierarchies to be ignored or replaced unexpectedly.
This change introduces MRO-based resolution for both slotted and dict-based classes, ensuring that intermediate setattr implementations are properly respected throughout the inheritance chain.
Adds and updates tests covering multiple inheritance and edge-case hierarchies to validate the fix. is this matches for this title Fix intermediate setattr handling in mixed inheritance chains