Fix duplicated exception chain output for exceptions without a traceback#14781
Open
SemTiOne wants to merge 1 commit into
Open
Fix duplicated exception chain output for exceptions without a traceback#14781SemTiOne wants to merge 1 commit into
SemTiOne wants to merge 1 commit into
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an exception in a chain has no
__traceback__of its own,repr_excinfo()falls back totraceback.format_exception(), which defaults tochain=Trueand walks the rest of the chain itself, duplicating what pytest's own chain-walking loop then prints again right after.Fix: pass
chain=Falseto that fallback call.Closes #8321
Co-authored-bycommit trailers.changelogdirectory, with a name like<ISSUE NUMBER>.<TYPE>.rst.AUTHORSin alphabetical order.