Replace string nodeids with a structured NodeId internally#14758

Open

nicoddemus wants to merge 27 commits into

pytest-dev:mainfrom

nicoddemus:refactor-node-ids

Commits on Jul 24, 2026

Replace string nodeids with a structured NodeId internally

nicoddemus
and
claude
committed
Add changelog entry for the NodeId refactor

nicoddemus
and
claude
committed
Turn nodeid string/NodeId conversion helpers into NodeId classmethods

nicoddemus
and
claude
committed
Make NodeId._str a lazily-computed cached attribute

nicoddemus
and
claude
committed
Improve docs
nicoddemus
committed
Remove NodeId.fspath, redundant with NodeId.path

nicoddemus
and
claude
committed
Assert the actual nodeid value in test_to_json_nodeid_wire_shape

nicoddemus
and
claude
committed
Split NodeId into NodeId (live collection) and OpaqueNodeId (external strings)

nicoddemus
and
claude
committed
Fix docs build warnings from the NodeId/OpaqueNodeId refactor

nicoddemus
and
claude
committed
Split NodeId into CollectionNodeId/ItemNodeId along the Collector/Item boundary

nicoddemus
and
claude
committed
Cache the original string directly in OpaqueNodeId.parse()

nicoddemus
and
claude
committed
Add NodeId.to_opaque() and use OpaqueNodeId as LFPlugin/NFPlugin's sole lookup type

nicoddemus
and
claude
committed
Add @override to _build_str implementations, moving the shim to compat.py

nicoddemus
and
claude
committed
Rename NodeId.to_opaque to as_opaque, add OpaqueNodeId.as_opaque

nicoddemus
and
claude
committed
Use an explicit match statement in coerce_node_id

nicoddemus
and
claude
committed
Review changes
nicoddemus
committed
Move comment
nicoddemus
committed
Rename _pytest._nodeid to _pytest.nodeid

nicoddemus
and
claude
committed
Fix stale CallSpec2 reference in ParamId docstring after rebase

nicoddemus
and
claude
committed
Fix grammar
nicoddemus
committed
Use slots=True/kw_only=True on nodeid.py dataclasses

nicoddemus
and
claude
committed
Doc changes
nicoddemus
committed
Remove cross-type equality between CollectionNodeId/ItemNodeId/OpaqueNodeId

nicoddemus
and
claude
committed
Remove str support from Node.__init__'s nodeid parameter

nicoddemus
and
claude
committed
Add a runtime check that Node.__init__'s nodeid is a NodeId or None

nicoddemus
and
claude
committed
Remove Node.__hash__

nicoddemus
and
claude
committed
Fold _WithNodeId into BaseReport; use match in junitxml's node_reporter

nicoddemus
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Replace string nodeids with a structured NodeId internally#14758

Replace string nodeids with a structured NodeId internally#14758
nicoddemus wants to merge 27 commits into
pytest-dev:mainfrom
nicoddemus:refactor-node-ids

Commits on Jul 24, 2026

Replace string nodeids with a structured NodeId internally

Add changelog entry for the NodeId refactor

Turn nodeid string/NodeId conversion helpers into NodeId classmethods

Make NodeId._str a lazily-computed cached attribute

Improve docs

Remove NodeId.fspath, redundant with NodeId.path

Assert the actual nodeid value in test_to_json_nodeid_wire_shape

Split NodeId into NodeId (live collection) and OpaqueNodeId (external strings)

Fix docs build warnings from the NodeId/OpaqueNodeId refactor

Split NodeId into CollectionNodeId/ItemNodeId along the Collector/Item boundary

Cache the original string directly in OpaqueNodeId.parse()

Add NodeId.to_opaque() and use OpaqueNodeId as LFPlugin/NFPlugin's sole lookup type

Add @override to _build_str implementations, moving the shim to compat.py

Rename NodeId.to_opaque to as_opaque, add OpaqueNodeId.as_opaque

Use an explicit match statement in coerce_node_id

Review changes

Move comment

Rename _pytest._nodeid to _pytest.nodeid

Fix stale CallSpec2 reference in ParamId docstring after rebase

Fix grammar

Use slots=True/kw_only=True on nodeid.py dataclasses

Doc changes

Remove cross-type equality between CollectionNodeId/ItemNodeId/OpaqueNodeId

Remove str support from Node.init's nodeid parameter

Add a runtime check that Node.init's nodeid is a NodeId or None

Remove Node.hash

Fold _WithNodeId into BaseReport; use match in junitxml's node_reporter