[pre-commit.ci] pre-commit autoupdate by pre-commit-ci[bot] · Pull Request #14175 · pytest-dev/pytest

pre-commit-ci · 2026-02-09T22:14:41Z

updates:

github.com/astral-sh/ruff-pre-commit: v0.14.14 → v0.15.4
github.com/tox-dev/pyproject-fmt: v2.12.1 → v2.12.1 our fork which won't change

Pierre-Sassoulas · 2026-02-14T07:24:52Z

I think this is good to go, enabling the new ruff message about using context manager can probably constitute a merge request on its own.

pyproject.toml

webknjaz · 2026-02-14T08:40:11Z

pyproject.toml

-directory = "misc"
-name = "Miscellaneous internal changes"
-showcontent = true
+type = [


I'd rather move this to a towncrier.toml than have this weird formatting..

pyproject-fmt gets more and more developer-hostile. i started to drop it from projects as ever since 2.x it messes up more and more things

Let's freeze it ? Might need to fork it so it's not upgraded automatically by pre-commit

I never liked it for myself so I'd normally just avoid integrating it in the first place. Though, it's my problem with most of the "opinionated" tools...

I forked the pyproject-fmt project and pushed the v2.12.1 tag to our fork so we can have auto-formatting without the opinionated changes.

pyproject.toml

webknjaz · 2026-03-02T20:10:16Z

pyproject.toml

    "PLW2901", # for loop variable overwritten by assignment target
    # ruff ignore
    "RUF012", # Mutable class attributes should be annotated with `typing.ClassVar`
+    "RUF061", # Use context-manager form of `pytest.raises()`


Why ignore this globally? I'd only disable it inline in a few places where the other format is being tested.

This is a lot of work (60+ violations), more suited to another merge request.

webknjaz · 2026-03-02T20:10:45Z

pyproject.toml

 lint.per-file-ignores."src/_pytest/_version.py" = [
    "I001",
 ]
+lint.per-file-ignores."testing/**/*.py" = [ "RUF060" ]


I suppose this also deserves a justification. Dunno what this rule number is...

Suggested change

lint.per-file-ignores."testing/**/*.py" = [ "RUF060" ]

# 'Unnecessary membership test on empty collection', always voluntary in tests

lint.per-file-ignores."testing/**/*.py" = [ "RUF060" ]

webknjaz · 2026-03-02T20:12:59Z

src/_pytest/config/findpaths.py


    def get_file_part_from_node_id(x: str) -> str:
-        return x.split("::")[0]
+        return x.split("::", maxsplit=1)[0]


This isn't a formatting change — do we need a change note mentioning refactoring?

It's a small optimization, but we could add a changelog for this (and the other). Let me know what you think.

webknjaz · 2026-03-02T20:14:18Z

src/_pytest/timing.py

    # Creation time of this instant, using time.time(), to measure actual time.
    # Note: using a `lambda` to correctly get the mocked time via `MockTiming`.
-    time: float = dataclasses.field(default_factory=lambda: time(), init=False)
+    time: float = dataclasses.field(default_factory=lambda: time(), init=False)  # noqa: PLW0108


Could you add a justification comment explaining what the rule demands?

Suggested change

time: float = dataclasses.field(default_factory=lambda: time(), init=False) # noqa: PLW0108

# So disabling pylint's 'unnecessary-lambda' / 'PLW0108' in ruff

time: float = dataclasses.field(default_factory=lambda: time(), init=False) # noqa: PLW0108

It's already justified by the comment, sadly ruff do not have the pylint naming scheme that make it self evident what's being noqaed

We could also disable for pylint and remove the project disable, the pylint disable-next replace the comment and serves a purpose

Suggested change

time: float = dataclasses.field(default_factory=lambda: time(), init=False) # noqa: PLW0108

# pylint: disable-next=lambda-assignment

time: float = dataclasses.field(default_factory=lambda: time(), init=False) # noqa: PLW0108

updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.14 → v0.15.4](astral-sh/ruff-pre-commit@v0.14.14...v0.15.4)

…kTiming`

updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.14 → v0.15.5](astral-sh/ruff-pre-commit@v0.14.14...v0.15.5) - [github.com/woodruffw/zizmor-pre-commit: v1.22.0 → v1.23.1](zizmorcore/zizmor-pre-commit@v1.22.0...v1.23.1) - [github.com/codespell-project/codespell: v2.4.1 → v2.4.2](codespell-project/codespell@v2.4.1...v2.4.2)

webknjaz assigned Pierre-Sassoulas Feb 10, 2026

Pierre-Sassoulas force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 6549b7e to e7092a9 Compare February 13, 2026 07:34

Pierre-Sassoulas enabled auto-merge February 14, 2026 07:24

Pierre-Sassoulas requested a review from webknjaz February 14, 2026 07:25

Pierre-Sassoulas added the skip news used on prs to opt out of the changelog requirement label Feb 14, 2026

webknjaz reviewed Feb 14, 2026

View reviewed changes

pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from e7092a9 to 30cae01 Compare February 16, 2026 20:52

Pierre-Sassoulas force-pushed the pre-commit-ci-update-config branch from c5ae88f to 167ca3f Compare February 16, 2026 22:13

pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 167ca3f to cc6dac9 Compare February 23, 2026 21:24

Pierre-Sassoulas force-pushed the pre-commit-ci-update-config branch 3 times, most recently from 9fd6b83 to c6e3a59 Compare February 27, 2026 09:17

Pierre-Sassoulas requested a review from webknjaz March 2, 2026 13:34

webknjaz reviewed Mar 2, 2026

View reviewed changes

pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from c9e7b99 to 2c4200d Compare March 9, 2026 21:38

Pierre-Sassoulas and others added 6 commits March 9, 2026 23:03

[pre-commit] Fix the version of pyproject-fmt by using our fork

a561283

[ruff] Upgrade ruff to 0.15.4

bbe9e54

updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.14 → v0.15.4](astral-sh/ruff-pre-commit@v0.14.14...v0.15.4)

[ruff-fmt] Nudge the auto-formatter to properly separate lines

88cf8df

[lint] PLW0108: lambda used to correctly get the mocked time via `Moc…

bccb763

…kTiming`

[pylint] sort the disable alphabetically, remove duplicate

829187e

Pierre-Sassoulas force-pushed the pre-commit-ci-update-config branch from 29d8742 to e5ab9be Compare March 9, 2026 22:07

	lint.per-file-ignores."testing/*/.py" = [ "RUF060" ]
	# 'Unnecessary membership test on empty collection', always voluntary in tests
	lint.per-file-ignores."testing/*/.py" = [ "RUF060" ]

	time: float = dataclasses.field(default_factory=lambda: time(), init=False) # noqa: PLW0108
	# So disabling pylint's 'unnecessary-lambda' / 'PLW0108' in ruff
	time: float = dataclasses.field(default_factory=lambda: time(), init=False) # noqa: PLW0108

	time: float = dataclasses.field(default_factory=lambda: time(), init=False) # noqa: PLW0108
	# pylint: disable-next=lambda-assignment
	time: float = dataclasses.field(default_factory=lambda: time(), init=False) # noqa: PLW0108

Uh oh!

Conversation

pre-commit-ci bot commented Feb 9, 2026 • edited by Pierre-Sassoulas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pierre-Sassoulas commented Feb 14, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pierre-Sassoulas Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pierre-Sassoulas Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pre-commit-ci bot commented Feb 9, 2026 •

edited by Pierre-Sassoulas

Loading

Pierre-Sassoulas Mar 9, 2026 •

edited

Loading

Pierre-Sassoulas Mar 9, 2026 •

edited

Loading