feat(mpv): use single instance of mpv#638
Open
citosid wants to merge 1 commit intopystardust:masterfrom
Open
Conversation
This commit configures mpv to create an ipc-server and re-use it to playback the files so no new instances are created Issue pystardust#637
Collaborator
|
There is one problem that may occur where if there is more than 1 mpv instance open it could pick the wrong one. for this line of code
I would use Lastly, could you use the Other than that it looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit configures mpv to create an ipc-server and re-use it to playback the files so no new instances are created
Issue #637