Open
Conversation
cfbolz
force-pushed
the
record-known-result
branch
from
f27ca79 to
c799a13
Compare
mattip
reviewed
May 22, 2022
mattip
reviewed
May 22, 2022
mattip
reviewed
May 22, 2022
mattip
reviewed
May 22, 2022
mattip
reviewed
May 22, 2022
Comment on lines
+78
to
+79
| This is all very useful! But it's still only a limited amount of things that | ||
| the interpreter author can express to the JIT with this one function decorator. |
Member
There was a problem hiding this comment.
Do we have a list of hints we could link to?
Suggested change
| This is all very useful! But it's still only a limited amount of things that | |
| the interpreter author can express to the JIT with this one function decorator. | |
| This is all very useful! There are additional hints | |
| the interpreter author can express to the JIT. |
Member
Author
There was a problem hiding this comment.
I was trying to look in our docs, but seems the answer unfortunately is "no, not at all" :-(
(and in general the docs are quite bad around the jit)
mattip
reviewed
May 22, 2022
mattip
reviewed
May 22, 2022
mattip
reviewed
May 22, 2022
mattip
reviewed
May 22, 2022
mattip
reviewed
May 22, 2022
mattip
reviewed
May 22, 2022
mattip
reviewed
May 22, 2022
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Co-authored-by: Matti Picus <matti.picus@gmail.com>
mattip
reviewed
May 23, 2022
Member
mattip
left a comment
mattip
left a comment
There was a problem hiding this comment.
Looks good. A few more for you to consider.
| @@ -0,0 +1,523 @@ | |||
| .. title: A Hint for Language-Specific Runtime Function Optimization in RPython's Meta-JIT | |||
Member
There was a problem hiding this comment.
shorter, and with a nod to the discussion of various JIT strategies
Suggested change
| .. title: A Hint for Language-Specific Runtime Function Optimization in RPython's Meta-JIT | |
| .. title: Optimizing across RPython functions in RPython's Meta-JIT |
Co-authored-by: Matti Picus <matti.picus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not ready yet, trying to get a preview