Fix hardcoded reliance on pip#1882
Open
vpetrigo wants to merge 34 commits intopypa:masterfrom
Open
Conversation
juftin
reviewed
Jan 11, 2025
juftin
reviewed
Jan 11, 2025
juftin
suggested changes
Jan 11, 2025
juftin
approved these changes
Jan 11, 2025
vpetrigo
force-pushed
the
fix/hardcoded-reliance-on-pip
branch
from
56d4787 to
b1838f8
Compare
Address: juftin/hatch-pip-compile#85 # Conflicts: # src/hatch/cli/application.py
Switch from --directory to --python switch to simplify `uv pip install` command.
vpetrigo
force-pushed
the
fix/hardcoded-reliance-on-pip
branch
from
8dca06c to
c1f2e75
Compare
Author
|
@ofek would you please re-approve workflows once again, I fixed formatting errors reported. I am really sorry to bother you. 😔 |
Author
|
Not sure why 3.12 on Linux failed. Re-run that in my repo and it passed. 🤷 |
Author
|
Tests fail due to differences in rendering hatch/tests/cli/python/test_show.py Lines 18 to 19 in 9068758 The following update in with console.capture() as capture:
console.print(table, overflow="ignore", no_wrap=True, crop=False) |
ofek
requested changes
Mar 6, 2026
Contributor
ofek
left a comment
ofek
left a comment
There was a problem hiding this comment.
Thanks for your patience here!
| from functools import cached_property | ||
| from typing import TYPE_CHECKING, cast | ||
|
|
||
| from uv import find_uv_bin |
Author
There was a problem hiding this comment.
@ofek would you please tell me if any other changes are required, when you have time.😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the issue described here juftin/hatch-pip-compile#85.
As it was discussed there, since
hatchalready depends onuvthere is no need to rely onpipinstall during environment requirements resolution, because it may be not available.