Pin python-docs-theme to fix docs build#1935
Merged
cooperlees merged 2 commits intopypa:mainfrom Apr 25, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
==========================================
+ Coverage 79.69% 86.40% +6.71%
==========================================
Files 31 35 +4
Lines 4324 4458 +134
Branches 780 467 -313
==========================================
+ Hits 3446 3852 +406
+ Misses 721 429 -292
- Partials 157 177 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Please let me know if this needs a changelog entry. |
cooperlees
approved these changes
Apr 25, 2025
Contributor
cooperlees
left a comment
There was a problem hiding this comment.
Many thanks - Can not remember for the life of me why this didn't work
Locally I worked out why I didn't repro:
cooper@cooper-fedora-MJ0J8MTZ:~$ /tmp/tb/bin/python -V
Python 3.13.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI was installing Python Docs Theme from GitHub:
bandersnatch/requirements_docs.txt
Line 12 in f3e7640
And the theme recently dropped Python 3.10 and 3.11: python/python-docs-theme#234
But the CI is using 3.11:
bandersnatch/.github/workflows/doc_build.yml
Line 19 in f3e7640
The quickest fix is to pin
python-docs-theme==2025.2, which is the most recent release and still supports Python 3.11.There's another error when using Python 3.13 on the CI:
Details
https://github.com/hugovk/bandersnatch/actions/runs/14668936590/job/41170649424#step:6:51
A longer term fix is to dig into that, but I think this PR is fine for now?