gdbserver: honor resume_on_disconnect on last client detach - #2020
Open
jhqian wants to merge 1 commit into
Open
Conversation
The multi-client gdbserver resumes a halted target when the last GDB client detaches. This resume path did not consult the resume_on_disconnect session option, so the option had no effect on persistent gdbserver sessions where clients detach and reattach. Gate the resume on the option. Signed-off-by: Ryan QIAN <jianghao.qian@outlook.com>
Contributor
Author
|
The "Functional tests Mac" failure is infrastructure: the job was auto-failed with "no enabled agents online to process the request for more than 7 days" — no tests actually ran on macOS. The 7 reported failed test cases (gdbserver on max32630/nrf51/nrf52833, Linux + Windows) are the long-standing Gdb Test failures that automated_test.py has carried in IGNORE_FAILURE_TESTS since 2021 (c5c33c1, "test: automated_test: ignore failures of connect and gdb tests"). The failure point is the DWT watchpoint exhaustion section, unrelated to the resume_on_disconnect gate added here. All other functional tests pass on Linux and Windows with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multi-client gdbserver resumes a halted target when the last GDB client detaches. This resume path did not consult the resume_on_disconnect session option, so the option had no effect on persistent gdbserver sessions where clients detach and reattach. Gate the resume on the option.