Added exception handler image processor decorator#328
Draft
GermanHydrogen wants to merge 1 commit intopyobs:developfrom
Draft
Added exception handler image processor decorator#328GermanHydrogen wants to merge 1 commit intopyobs:developfrom
GermanHydrogen wants to merge 1 commit intopyobs:developfrom
Conversation
Member
|
Hmm, not a bad idea... But that moves error handling in the config file, which I find weird... The config also gets a lot more complex with this. What about adding that functionality to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative suggestion to implementing the exception handling in the image processor base class.
Doing this in the base class would introduce two new attributes
suppress_exception: boolwhich toggles the exception handling anderror_header: Optional[str]which defines the error header flat. This introduces the problem that theerror_headerattribute can be set without thesuppress_exceptionattribute being true, which could lead to errors in config management.The alternative decorator approach removes the need for the first attribute.
A config with this could look like this
I'm open to feedback.