Skip to content

Remove 3.5char frame time check. #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 1 commit into from
Mar 21, 2026
+0 −13
Merged

Remove 3.5char frame time check. #2912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions pymodbus/transport/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
from contextlib import suppress
from enum import Enum
from functools import partial
from time import time_ns
from typing import Any

from ..logging import Log
Expand Down Expand Up @@ -162,7 +161,6 @@ def __init__(
self.unique_id: str = str(id(self))
self.reconnect_delay_current = 0.0
self.sent_buffer: bytes = b""
self.inter_frame_time: float = 0.0
self.last_frame: int = 0
self.loop: asyncio.AbstractEventLoop
if is_sync:
Expand Down Expand Up @@ -199,11 +197,6 @@ def __init__(
def init_setup_connect_listen(self, host: str, port: int) -> None:
"""Handle connect/listen handler."""
if self.comm_params.comm_type == CommType.SERIAL:
if self.comm_params.baudrate > 38000:
self.inter_frame_time = 1e9
else:
# time to transmit 3Char with stop bits etc.
self.inter_frame_time = int(1e9 * 3.0 * (float(1 + self.comm_params.bytesize + self.comm_params.stopbits) / self.comm_params.baudrate))
self.call_create = partial(create_serial_connection,
self.loop,
self.handle_new_connection,
Expand Down Expand Up @@ -337,12 +330,6 @@ def datagram_received(self, data: bytes, addr: tuple | None) -> None:
if not data:
return
Log.transport_dump(Log.RECV_DATA, data, self.recv_buffer)
if self.inter_frame_time:
t_now = time_ns()
if t_now - self.last_frame >= self.inter_frame_time:
Log.debug("End Of Frame detected, clearing buffer: {}", self.recv_buffer, ":hex")
self.recv_buffer = b''
self.last_frame = t_now
if len(self.recv_buffer) > 1024:
self.recv_buffer = b''
self.recv_buffer += data
Expand Down
Loading