di is for discrete input#2842
Merged
janiversen merged 4 commits intopymodbus-dev:devfrom Jan 21, 2026
Merged
Conversation
"direct input" is not correct
janiversen
requested changes
Jan 19, 2026
Collaborator
janiversen
left a comment
janiversen
left a comment
There was a problem hiding this comment.
You have some how manages to change every line in the examples file, that cannot be correct, please only make needed changes.
In general the change direct to discrete is correct.
Contributor
Author
|
The change in every lines is because the end line was in CRLF, I changed it into LF like all other python files |
Collaborator
|
That should be in a separate PR, it is imposssible to review what is actually changed in the file. And the text of the PR must clearly store what have been changed. |
Contributor
Author
|
Somehow the line end was different on my repo clone, it should be solved now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"direct input" is not correct