Stop the frozen-generator check from rejecting inner-graph inputs - #87
Merged
jessegrabowski merged 3 commits intoAug 12, 2026
Merged
Conversation
An op carrying an inner graph may draw from a generator it receives or merely accept it, and only that inner graph knows which, so treating every non-output use as a draw rejected graphs that never draw at all. `collect_default_updates` already raises for an inner graph that draws without threading the generator back out.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 95.46% 96.73% +1.27%
==========================================
Files 45 45
Lines 1807 1807
==========================================
+ Hits 1725 1748 +23
+ Misses 82 59 -23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check that refuses a graph whose generator nothing advances counted any non-output use as a draw. An op carrying an inner graph might draw from a generator it's handed or might just accept it, so a layer that takes one without drawing got rejected with a message claiming the graph draws from it. Now only direct draw ops count — inner graphs are
collect_default_updates' business, and it already raises when one draws without threading the generator back out.Also restores the "here's how to fix it" half of the two inner-graph error messages, dropped when we vendored them from pymc.