Let a transformer block initialize its residual projections - #83
Merged
jessegrabowski merged 2 commits intoAug 11, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 95.46% 95.47%
=======================================
Files 45 45
Lines 1809 1811 +2
=======================================
+ Hits 1727 1729 +2
Misses 82 82 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing could reach the projections inside a transformer block, so GPT-style init — scale the two that write back into the residual stream, leave their siblings alone — was inexpressible. One keyword per level routes it now:
out_proj_initializeron attention,residual_initializeron the block, which feeds both that and the feed-forward's second layer.Biases stay unreachable on purpose: pinned to zero by declaration, which is what the models this serves want, and
bias=Falsecovers the ones that drop them. A one-off gets the per-parameter override coming next.