Numba scan: fix invalid cross alias and inplace#2263
Draft
ricardoV94 wants to merge 1 commit into
Draft
Conversation
ricardoV94
commented
Jun 27, 2026
ricardoV94
commented
Jun 27, 2026
ricardoV94
commented
Jun 27, 2026
ricardoV94
commented
Jun 27, 2026
ricardoV94
commented
Jun 27, 2026
ricardoV94
force-pushed
the
scan_sitsot_alias_bug
branch
2 times, most recently
from
e8add5b to
22842bd
Compare
ricardoV94
commented
Jun 27, 2026
ricardoV94
commented
Jun 27, 2026
ricardoV94
commented
Jun 27, 2026
jessegrabowski
approved these changes
Jun 27, 2026
ricardoV94
force-pushed
the
scan_sitsot_alias_bug
branch
from
22842bd to
dac65b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who knew memory optimization correctness is so hard?
This PR fixes #2252. I went on a rabbit hole of reassessing the whole memory optimization strategy in the numba dispatcher. I tried to have everything documented without going too close into an essay.