BUG FIX: scalar Pow.impl returning complex for fractional powers of negative floats#1945
Open
vybhav72954 wants to merge 2 commits intopymc-devs:v3from
Open
BUG FIX: scalar Pow.impl returning complex for fractional powers of negative floats#1945vybhav72954 wants to merge 2 commits intopymc-devs:v3from
vybhav72954 wants to merge 2 commits intopymc-devs:v3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pow.implinpytensor/scalar/basic.pyuses Python's native**operator, which returns complex numbers for fractional powers of negative floats (e.g.,(-1.0) ** 0.01returns(0.999+0.031j)). This is inconsistent with the tensor path, which already usesnp.powervianfunc_specand correctly returnsnan.The complex result then crashes
_cast_to_promised_scalar_dtypewhen it tries to cast tofloat64.Fix: Replace
x**ywithnp.power(x, y)inPow.impl, making the scalar path consistent with the tensor path.Related Issue
Checklist
Type of change