Change default cast_policy to numpy+floatX to fix float downcasting#1917
Change default cast_policy to numpy+floatX to fix float downcasting#1917ayulockedin wants to merge 2 commits intopymc-devs:mainfrom
Conversation
|
i have changed the default to see what the damage cuz i think all tests would also be relying on the old |
|
so here i have changed the defaults and now many tests are failling, so should i correct these tests as for example i did in |
d207389 to
32be6d7
Compare
|
@ricardoV94 i am sorry for pinging but this one would be a bit tricky and would take some time. Switching the default to I wanted to confirm this is the desired direction before I put in the effort to clear the remaining 30 failing modules. |
Description
This PR changes the default
cast_policyinconfigdefaults.pytonumpy+floatX. This removes the olderNumpyAutocastermachinery which was causing inconsistent float downcasting (e.g., downcasting9.0tofloat32while keeping8.9and9.1asfloat64).Opening this as a draft PR first to let the CI test suite evaluate the overall impact. Changing this core default will likely require updating type assertions across the broader test suite where the old downcasting behavior was explicitly expected.
Related Issue
Checklist
Type of change