Skip to content

Potion Altar#892

Open
balugaq wants to merge 24 commits intomasterfrom
balugaq/potion-altar
Open

Potion Altar#892
balugaq wants to merge 24 commits intomasterfrom
balugaq/potion-altar

Conversation

@balugaq
Copy link
Copy Markdown
Collaborator

@balugaq balugaq commented Mar 14, 2026

No description provided.

@balugaq balugaq self-assigned this Mar 14, 2026
@balugaq balugaq linked an issue Mar 14, 2026 that may be closed by this pull request
@balugaq balugaq marked this pull request as ready for review April 5, 2026 14:07
Copy link
Copy Markdown
Member

@Seggan Seggan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the concept and the execution in the multiblock. Maybe add some particles or smth specifically for when it's going through the crafting cycle?

Comment thread src/main/resources/lang/en.yml Outdated
Comment thread src/main/resources/lang/en.yml
Comment thread src/main/resources/lang/en.yml Outdated
Comment thread src/main/resources/settings/potion_altar.yml Outdated
Comment thread src/main/resources/lang/en.yml Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
@balugaq balugaq requested a review from Seggan April 11, 2026 15:28
@balugaq
Copy link
Copy Markdown
Collaborator Author

balugaq commented Apr 11, 2026

QQ20260411-231731.mp4

Also tested recipe-recovering

Copy link
Copy Markdown
Contributor

@LordIdra LordIdra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the idea and the visual implementation is really really nice

Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/PylonItems.java
Comment thread src/main/java/io/github/pylonmc/pylon/PylonItems.java Outdated
Comment thread src/main/resources/lang/en.yml Outdated
Comment thread src/main/resources/lang/en.yml Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/resources/lang/en.yml
Comment thread src/main/java/io/github/pylonmc/pylon/PylonItems.java
@LordIdra
Copy link
Copy Markdown
Contributor

Also forgot to mention, the catalyst are quite expensive to REALLY expensive for being single-use items. I would make them significantly cheaper

@balugaq
Copy link
Copy Markdown
Collaborator Author

balugaq commented Apr 17, 2026

Also forgot to mention, the catalyst are quite expensive to REALLY expensive for being single-use items. I would make them significantly cheaper

Now simplified more I think: replace abyssal_catalyst to covalent_binder

@balugaq
Copy link
Copy Markdown
Collaborator Author

balugaq commented Apr 17, 2026

tested

@balugaq balugaq requested a review from LordIdra April 17, 2026 17:49
Copy link
Copy Markdown
Contributor

@LordIdra LordIdra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think the ascendant ember recipe is still too expensive to be worth it, remove the shimmer dust 3 from the recipe? shimmer dust 3 is very annoying to make.

The potion altar should have its direction set with setMultiblockDirectional and should also be a RebarDirectionalBlock

Consider this approved once that is done

(Also I think it would be better if the potion altar catalysts used recipes and recipe processor instead but not going to request changes on that as the processor stuff is getting reworked soon anyway)

@balugaq
Copy link
Copy Markdown
Collaborator Author

balugaq commented Apr 18, 2026

Done.

by the way, a problem related to RebarTranslator:
QQ_1776497876287
This splash potion cannot be thrown out.

@balugaq balugaq requested a review from LordIdra April 18, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potion Altar

3 participants