Handle reserved STmin values per ISO-15765-2 - #160
Draft
fallenmi wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x7Finstead of discarding the framestminandstmin_secnormalized to the same effective 127 ms value0x7F/0xF9endpointsFixes #147.
Why
ISO 15765-2 requires reserved STmin values to be treated as
0x7F. The current parser raisesValueError, which causes the transport layer to discard an otherwise valid FlowControl frame.Testing
python3 -m unittest test.test_helper_classes.TestPDUDecoding.test_decode_flow_controlpython3 -m unittest test.test_helper_classes— 9 tests passedpython3 -m unittest— 164 tests run, 31 platform-specific skipsAI disclosure
This pull request was prepared with OpenAI Codex. Codex reproduced the issue, implemented the code and tests, audited visible upstream and fork overlap, and ran the validation listed above. This remains a Draft for the account owner's review.