feat: complete test harness for pyinfra facts and operations#2
Open
DonDebonair wants to merge 1 commit into
Open
feat: complete test harness for pyinfra facts and operations#2DonDebonair wants to merge 1 commit into
DonDebonair wants to merge 1 commit into
Conversation
Describe test cases for facts and operations using yaml/json. The test harness supports facts that return (nested) dataclasses. Operation arguments are automatically coerced into the proper types from the input yaml/json Test harness itself has a thorough test suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe test cases for facts and operations using yaml/json. The test harness supports facts that return (nested) dataclasses. Operation arguments are automatically coerced into the proper types from the input yaml/json
Test harness itself has a thorough test suite.
The basics for this test harness were ported from pyinfra and then it was augmented to support more types of facts and operations.
The test harness was tested against the full pyinfra test suite and against my own custom facts + operations for proxmox (will open source those once this has been merged).
NOTE: all the type coercion happening here is quite complex. In the future I'd like to take our learnings from the yaml/json test harness to create an actual type safe test harness that has a similar dev experience.