Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions xarray/namedarray/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ def module_available(module: str, minversion: str | None = None) -> bool:
if minversion is not None:
version = importlib.metadata.version(module)

if version is None:
return False

return Version(version) >= Version(minversion)

return True
Expand Down
19 changes: 19 additions & 0 deletions xarray/tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from collections.abc import Hashable
from types import EllipsisType
from unittest.mock import patch

import numpy as np
import pandas as pd
Expand All @@ -15,6 +16,7 @@
infix_dims,
iterate_nested,
)
from xarray.namedarray.utils import module_available
from xarray.tests import assert_array_equal, requires_dask


Expand Down Expand Up @@ -391,6 +393,23 @@ def f():
assert f() == 3


# regression test
def test_module_available_with_none_version() -> None:
module_available.cache_clear()

try:
with (
patch("importlib.util.find_spec", return_value=object()),
patch("importlib.metadata.version", return_value=None),
):
assert not module_available(
"package_with_missing_version",
minversion="1.0",
)
finally:
module_available.cache_clear()


def test_attempt_import() -> None:
"""Test optional dependency handling."""
np = attempt_import("numpy")
Expand Down
Loading