Fix concat failure with pandas StringDtype indexes (#11317)#11322
Open
SAY-5 wants to merge 1 commit intopydata:mainfrom
Open
Fix concat failure with pandas StringDtype indexes (#11317)#11322SAY-5 wants to merge 1 commit intopydata:mainfrom
SAY-5 wants to merge 1 commit intopydata:mainfrom
Conversation
Signed-off-by: SAY-5 <say.apm35@gmail.com>
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11317. When
pandasreturns aStringDtype-backedIndex(e.g. withfuture.infer_stringenabled or pandas 3.x defaults), passing it as the new concat dim caused_calc_concat_dim_indexto store theStringDtypeas the resultingPandasIndex.coord_dtype. A subsequent concat against another input with a numpy<U*coord then failed innp.result_typewithTypeError: Cannot interpret '<StringDtype...>' as a data type.PandasIndex.__init__already coerces non-allowed extension dtypes viaget_valid_numpy_dtypewhencoord_dtypeisNone; this PR reuses that path forStringDtypeso the resulting coord ends up asobjectand concat succeeds. Regression test added.Checklist
whats-new.rstapi.rstAI Disclosure
Tools: Claude. I directed the agent to localize the failure to
_calc_concat_dim_indexinxarray/structure/concat.py, evaluated alternative fix sites (PandasIndex.concatvs the dim-index helper), reviewed and tested the resulting patch, and confirmed the regression test fails onmainand passes here.