Skip to content

fix(cmake): don't link SHARED modules against libpython in FindPython mode #6140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henryiii wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −4
Open

fix(cmake): don't link SHARED modules against libpython in FindPython mode #6140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions tools/pybind11NewTools.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,13 @@ function(pybind11_add_module target_name)
set(lib_type MODULE)
endif()

if("${_Python}" STREQUAL "Python")
if(lib_type STREQUAL "SHARED")
# Bypass python_add_library, which links SHARED libraries against libpython.
# An extension module must not link libpython on macOS; with a statically
# linked interpreter (e.g. python-build-standalone) that loads a second
# Python runtime and aborts on import. Matches classic pybind11Tools.cmake.
add_library(${target_name} SHARED ${ARG_UNPARSED_ARGUMENTS})
elseif("${_Python}" STREQUAL "Python")
python_add_library(${target_name} ${lib_type} ${ARG_UNPARSED_ARGUMENTS})
elseif("${_Python}" STREQUAL "Python3")
python3_add_library(${target_name} ${lib_type} ${ARG_UNPARSED_ARGUMENTS})
Expand All @@ -276,10 +282,10 @@ function(pybind11_add_module target_name)

target_link_libraries(${target_name} PRIVATE pybind11::headers)

if(lib_type STREQUAL "MODULE")
target_link_libraries(${target_name} PRIVATE pybind11::module)
else()
if(lib_type STREQUAL "STATIC")
target_link_libraries(${target_name} PRIVATE pybind11::embed)
else()
target_link_libraries(${target_name} PRIVATE pybind11::module)
endif()

# -fvisibility=hidden is required to allow multiple modules compiled against
Expand Down
Loading