type_caster_generic: fix compiler error when casting a T that is implicitly convertible from T* #5873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icitly convertible from T*
rwgk
approved these changes
Oct 15, 2025
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
I went ahead and added commit 384ab4c96618f69c09cad886bca2f4658d378232
(I'm set up to run clang-tidy locally)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression from #5866; see the comments towards the end of that PR. Since the call to
cast()invoked an implicit conversion fromconst itype*tocast_sources, it could be ambiguous with an implicit conversion fromconst itype*toconst itype&oritype&&. Since the latter is under the control of the user, we need to handle the possibility of it existing. Fix by making the cast_sources constructors fromconst itype*be explicit, and adding forwarding wrappers to allow passing a directconst itype*to cast() and cast_holder().