Skip to content

Remove unused clearsky._is_leap_year (closes #2768)#2813

Merged
cwhanse merged 5 commits into
pvlib:mainfrom
dgowdaan-cmyk:remove-is-leap-year
Jul 7, 2026
Merged

Remove unused clearsky._is_leap_year (closes #2768)#2813
cwhanse merged 5 commits into
pvlib:mainfrom
dgowdaan-cmyk:remove-is-leap-year

Conversation

@dgowdaan-cmyk

@dgowdaan-cmyk dgowdaan-cmyk commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Closes #2768

Removes the unused internal function clearsky._is_leap_year. Verified via repo-wide search that it has no other references anywhere in the codebase. Per maintainer (@cwhanse), no deprecation cycle or new test required — see comment.

  • Closes Remove dead code clearsky._is_leap_year #2768
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:num or this Pull Request with `:pull:`num. Includes contributor name and/or GitHub username (link with :ghuser:user``).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@dgowdaan-cmyk

Copy link
Copy Markdown
Contributor Author

@cwhanse This is ready for review whenever you get a chance. Summary of the change:

  • Removed clearsky._is_leap_year (unused, verified via repo-wide search — no other references in the codebase)
  • Updated the whatsnew entry under Maintenance
  • No deprecation cycle or new tests added, per your comment on Remove dead code clearsky._is_leap_year #2768

Let me know if anything else is needed on my end

Comment thread docs/sphinx/source/whatsnew/v0.15.3.rst Outdated
Comment thread docs/sphinx/source/whatsnew/v0.15.3.rst Outdated
@cwhanse cwhanse added this to the v0.15.3 milestone Jul 7, 2026
@cwhanse

cwhanse commented Jul 7, 2026

Copy link
Copy Markdown
Member

@dgowdaan-cmyk sorry to be a stickler, but your AI, IDE or linter is removing blank lines from the whatsnew file. Can you put those back? Removing them may create conflicts for other PRs working in parallel.

@dgowdaan-cmyk

dgowdaan-cmyk commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

No worries at all, good catch! Blank lines are restored and I double-checked the diff against main — the only changes now are the two intended lines (the pull number and my contributor entry), nothing else touched. Let me know if anything else needs adjusting.

@cwhanse

cwhanse commented Jul 7, 2026

Copy link
Copy Markdown
Member

Test failure is unrelated here.

@cwhanse

cwhanse commented Jul 7, 2026

Copy link
Copy Markdown
Member

thanks @dgowdaan-cmyk

@cwhanse cwhanse merged commit df60945 into pvlib:main Jul 7, 2026
30 of 31 checks passed
@dgowdaan-cmyk

Copy link
Copy Markdown
Contributor Author

Thanks @cwhanse! Appreciate you walking through the review comments with me 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead code clearsky._is_leap_year

2 participants