Skip to content

Modernize: skillcheck lint, AGENTS routing, gate hardening, issue forms - #62

Merged
altaywtf merged 5 commits into
mainfrom
chore/modernize-61
Aug 19, 2026
Merged

Modernize: skillcheck lint, AGENTS routing, gate hardening, issue forms#62
altaywtf merged 5 commits into
mainfrom
chore/modernize-61

Conversation

@altaywtf

Copy link
Copy Markdown
Member

Summary

Fixes #61. WS2/WS3 consistency wave from the repo modernization program: coverage becomes a real gate, skill lint joins verify, agent routing lands in AGENTS.md, and issue templates become YAML forms.

Changed

  • AGENTS.md: Start Here routing block (README, docs/DEBUGGING.md, docs/DISTRIBUTION.md, skills/rokit/); the CLAUDE.md-symlink line now states the existing symlink as fact.
  • package.json: dropped --passWithNoTests from test and verify; verify now runs vp test run --coverage and skillcheck lint; added coverage and skills:lint scripts.
  • vite.config.ts: v8 coverage over src/**/*.ts (bin entry src/rokit.ts excluded, mirroring putio-cli's src/bin.ts exclusion) with a threshold floor of 63/51/55/63 (statements/branches/functions/lines). Measured baseline: 65.91/53.42/57.86/65.83.
  • @uinaf/skillcheck exact-pinned at 0.4.0; skills/rokit/SKILL.md frontmatter gained a don't-use clause matching the generic-vs-product boundary in the body.
  • pnpm-workspace.yaml: @vitest/coverage-v8 catalog entry; skillcheck's eval-only optional deps get allowBuilds: false (lint needs no build scripts).
  • .github/ISSUE_TEMPLATE/: bug_report.md and feature_request.md converted to YAML forms with required fields.

Risks

  • Coverage floor sits ~3 points under the measured baseline; a large untested module would still need tests before landing, which is the point.
  • YAML forms enforce required fields that the legacy templates only suggested.

Verification

  • vp run verify exit 0 locally: check, skillcheck lint (1 package clean), typecheck, pack, smoke, 12 test files with coverage above floor, npm pack dry-run.
  • Pre-push hook ran the same pnpm verify on push.

Follow-Ups

None; adjacent findings go to putdotio/putio-frontend#24.

altaywtf and others added 4 commits August 19, 2026 22:31
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Drop --passWithNoTests from test/verify, gate coverage at
63/51/55/63 (statements/branches/functions/lines; measured
65.91/53.42/57.86/65.83), and chain skillcheck lint into verify.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 19, 2026 19:31
…escription

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the repo’s “quality gates” and contributor workflows by making coverage and skill lint part of the standard verification path, improving agent-facing routing documentation, and migrating GitHub issue templates to YAML issue forms.

Changes:

  • Adds Vitest v8 coverage configuration (include/exclude + thresholds) and wires --coverage into verify.
  • Adds @uinaf/skillcheck and runs skillcheck lint as part of verify (plus a dedicated skills:lint script).
  • Updates AGENTS routing guidance and converts legacy GitHub issue templates from Markdown to YAML forms.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vite.config.ts Adds v8 coverage reporting + threshold gates for Vitest runs.
package.json Updates scripts to enforce coverage in verify, removes --passWithNoTests, and adds skill lint scripts/deps.
pnpm-workspace.yaml Adds catalog entry for coverage provider and extends workspace policy lists for modernization tooling.
skills/rokit/SKILL.md Tightens frontmatter guidance to reinforce generic-vs-product boundary for the skill.
AGENTS.md Adds “Start Here” routing block and clarifies CLAUDE.md symlink status.
.github/ISSUE_TEMPLATE/bug_report.yml Replaces legacy Markdown template with YAML issue form and required fields.
.github/ISSUE_TEMPLATE/feature_request.yml Replaces legacy Markdown template with YAML issue form and required fields.
.github/ISSUE_TEMPLATE/bug_report.md Removes legacy Markdown issue template.
.github/ISSUE_TEMPLATE/feature_request.md Removes legacy Markdown issue template.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread vite.config.ts
@altaywtf
altaywtf merged commit 12838c7 into main Aug 19, 2026
2 checks passed
@altaywtf
altaywtf deleted the chore/modernize-61 branch August 19, 2026 19:39
@putio-releaser

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modernize: skillcheck lint, AGENTS routing, gate hardening, issue forms

2 participants