Modernize: skillcheck lint, AGENTS routing, gate hardening, issue forms - #62
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Drop --passWithNoTests from test/verify, gate coverage at 63/51/55/63 (statements/branches/functions/lines; measured 65.91/53.42/57.86/65.83), and chain skillcheck lint into verify. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…escription Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR modernizes the repo’s “quality gates” and contributor workflows by making coverage and skill lint part of the standard verification path, improving agent-facing routing documentation, and migrating GitHub issue templates to YAML issue forms.
Changes:
- Adds Vitest v8 coverage configuration (include/exclude + thresholds) and wires
--coverageintoverify. - Adds
@uinaf/skillcheckand runsskillcheck lintas part ofverify(plus a dedicatedskills:lintscript). - Updates AGENTS routing guidance and converts legacy GitHub issue templates from Markdown to YAML forms.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
vite.config.ts |
Adds v8 coverage reporting + threshold gates for Vitest runs. |
package.json |
Updates scripts to enforce coverage in verify, removes --passWithNoTests, and adds skill lint scripts/deps. |
pnpm-workspace.yaml |
Adds catalog entry for coverage provider and extends workspace policy lists for modernization tooling. |
skills/rokit/SKILL.md |
Tightens frontmatter guidance to reinforce generic-vs-product boundary for the skill. |
AGENTS.md |
Adds “Start Here” routing block and clarifies CLAUDE.md symlink status. |
.github/ISSUE_TEMPLATE/bug_report.yml |
Replaces legacy Markdown template with YAML issue form and required fields. |
.github/ISSUE_TEMPLATE/feature_request.yml |
Replaces legacy Markdown template with YAML issue form and required fields. |
.github/ISSUE_TEMPLATE/bug_report.md |
Removes legacy Markdown issue template. |
.github/ISSUE_TEMPLATE/feature_request.md |
Removes legacy Markdown issue template. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
🎉 This PR is included in version 2.4.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #61. WS2/WS3 consistency wave from the repo modernization program: coverage becomes a real gate, skill lint joins
verify, agent routing lands in AGENTS.md, and issue templates become YAML forms.Changed
AGENTS.md: Start Here routing block (README, docs/DEBUGGING.md, docs/DISTRIBUTION.md, skills/rokit/); the CLAUDE.md-symlink line now states the existing symlink as fact.package.json: dropped--passWithNoTestsfromtestandverify;verifynow runsvp test run --coverageandskillcheck lint; addedcoverageandskills:lintscripts.vite.config.ts: v8 coverage oversrc/**/*.ts(bin entrysrc/rokit.tsexcluded, mirroring putio-cli'ssrc/bin.tsexclusion) with a threshold floor of 63/51/55/63 (statements/branches/functions/lines). Measured baseline: 65.91/53.42/57.86/65.83.@uinaf/skillcheckexact-pinned at0.4.0;skills/rokit/SKILL.mdfrontmatter gained a don't-use clause matching the generic-vs-product boundary in the body.pnpm-workspace.yaml:@vitest/coverage-v8catalog entry; skillcheck's eval-only optional deps getallowBuilds: false(lint needs no build scripts)..github/ISSUE_TEMPLATE/:bug_report.mdandfeature_request.mdconverted to YAML forms with required fields.Risks
Verification
vp run verifyexit 0 locally: check, skillcheck lint (1 package clean), typecheck, pack, smoke, 12 test files with coverage above floor, npm pack dry-run.pnpm verifyon push.Follow-Ups
None; adjacent findings go to putdotio/putio-frontend#24.