Fix ENODATA and unrecognised POSIX errors not treated as disconnections#64
Merged
Keith-wright merged 1 commit intomainfrom Mar 3, 2026
Merged
Fix ENODATA and unrecognised POSIX errors not treated as disconnections#64Keith-wright merged 1 commit intomainfrom
Keith-wright merged 1 commit intomainfrom
Conversation
aonemd
added
release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62
When a WebSocket connection receives POSIX error 96 (ENODATA: "No message available on STREAM"), the previous
isDisconnectionNWErrorcheck did not recognise it, leaving theNWConnectionin a zombie.readystate. Subsequent reconnect attempts would reuse the dead connection and immediately fail with the same error, causing an unrecoverable reconnection loop.Changes
else if case .posix(_)branch toisDisconnectionNWErrorto handle ENODATA and any other unrecognised POSIX errors that also indicate a dead connectionconnection?.cancel()before scheduling disconnection reporting to ensure the zombieNWConnectionis torn down so a fresh one is created on reconnectThanks to @joelmbell for the suggestion in #63.