Split Registry read and write effects#785
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b54-076c-701a-863f-75106cd6f5bd Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b54-076c-701a-863f-75106cd6f5bd Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
f-f
force-pushed
the
issue-722-split-registry-effects
branch
from
July 22, 2026 21:37
83fb1c3 to
7c1e2cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #722 (and does a bit more). In that issue we were specifically concerned with splitting
REGISTRYinto read/write effects, so it's more obvious when a function is only reading from the registry and not modifying it. However, along the way, I noticed that we don't need theGITHUBeffect in the read handler either, so I went ahead and removed it. I did a little overall audit through the codebase to make sure each function is using the least effects required to get the job done.Some basic notes on what was done:
REGISTRY_READandREGISTRY_WRITE, while retainingREGISTRYas a convenience alias for workflows that need bothLOG + AFF + EFFECT; only the write handler retainsGITHUB