Skip to content

Split Registry read and write effects#785

Merged
thomashoneyman merged 2 commits into
masterfrom
issue-722-split-registry-effects
Jul 22, 2026
Merged

Split Registry read and write effects#785
thomashoneyman merged 2 commits into
masterfrom
issue-722-split-registry-effects

Conversation

@thomashoneyman

@thomashoneyman thomashoneyman commented Jul 22, 2026

Copy link
Copy Markdown
Member

Closes #722 (and does a bit more). In that issue we were specifically concerned with splitting REGISTRY into read/write effects, so it's more obvious when a function is only reading from the registry and not modifying it. However, along the way, I noticed that we don't need the GITHUB effect in the read handler either, so I went ahead and removed it. I did a little overall audit through the codebase to make sure each function is using the least effects required to get the job done.

Some basic notes on what was done:

  • split the Registry effect into REGISTRY_READ and REGISTRY_WRITE, while retaining REGISTRY as a convenience alias for workflows that need both
  • give Registry reads a handler that emits only LOG + AFF + EFFECT; only the write handler retains GITHUB
  • audit production, server, script, E2E, and test effect rows so each path receives the minimum Registry responsibility it needs
  • remove transitive GitHub credentials, Octokit clients, caches, and interpreters from PackageSetUpdater, VerifyIntegrity, and the real Registry read-handler test
  • preserve the shared Registry environment, memory cache, debouncer, pull machinery, and existing publication/retry behavior

@f-f f-f left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful stuff!

thomashoneyman and others added 2 commits July 23, 2026 00:37
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b54-076c-701a-863f-75106cd6f5bd

Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b54-076c-701a-863f-75106cd6f5bd

Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
@f-f
f-f force-pushed the issue-722-split-registry-effects branch from 83fb1c3 to 7c1e2cc Compare July 22, 2026 21:37
@thomashoneyman
thomashoneyman merged commit 97b854d into master Jul 22, 2026
7 checks passed
@thomashoneyman
thomashoneyman deleted the issue-722-split-registry-effects branch July 22, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split the REGISTRY effect into REGISTRY_READ and REGISTRY_WRITE

2 participants