Add a mode parameter to manage repository root directory permission#599
Open
robbat2 wants to merge 1 commit intopuppetlabs:mainfrom
Open
Add a mode parameter to manage repository root directory permission#599robbat2 wants to merge 1 commit intopuppetlabs:mainfrom
mode parameter to manage repository root directory permission#599robbat2 wants to merge 1 commit intopuppetlabs:mainfrom
Conversation
|
|
Author
|
@david22swan can this be merged please? |
|
Hey @robbat2, this Pull Request needs a rebase and conflict resolution. Once that is done, I will be happy to review. |
Author
|
Rebased now, watching to see that CI passes |
Author
|
@LukasAud can you approve it for CI please? |
smortex
reviewed
Jul 13, 2023
smortex
changed the title
mode parameter to manage repository root directory permission
Splits set_ownership_and_permissions into seperate functions per Metrics/CyclomaticComplexity & Metrics/PerceivedComplexity rubocop checks. Signed-off-by: Robin H. Johnson <robbat2@gentoo.org> Reference: puppetlabs#598
Author
|
@smortex fixed those issues as part of a rebase, plus the rubocop style checks. Please approve CI again |
|
@robbat2 , could you please update the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
modeoption per #598 feature request.Reference: #598