(CAT-2451) Address wrong facter consumption#156
Merged
gavindidrichsen merged 3 commits intomainfrom Jan 13, 2026
Merged
Conversation
Recently, we realised there was something wrong with the way facter was being consumed in our module acceptance tests. We noticed it seemed to be stuck on the first version of private facter instead of latest. Upon investigation, we found the issue was that we were consuming an unreleased version of public facter instead of the intended one. This commit addressed this issue by pointing to the right repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, we realised there was something wrong with the way facter was being consumed in our module acceptance tests. We noticed it seemed to be stuck on the first version of private facter instead of latest. Upon investigation, we found the issue was that we were consuming an unreleased version of public facter instead of the intended one.
This commit addressed this issue by pointing to the right repository.
Tested in
https://github.com/puppetlabs/puppetlabs-motd/actions/runs/20955453858/job/60221786816?pr=538#step:5:201
https://github.com/puppetlabs/puppetlabs-motd/actions/runs/20955453858/job/60221787498?pr=538#step:7:203
Checklist