Skip to content

fix: OCI ordering, RBE docs, and WRPC tests (#14, #18, #34)#344

Open
avrabe wants to merge 1 commit intomainfrom
fix-issues-14-18-34
Open

fix: OCI ordering, RBE docs, and WRPC tests (#14, #18, #34)#344
avrabe wants to merge 1 commit intomainfrom
fix-issues-14-18-34

Conversation

@avrabe
Copy link
Contributor

@avrabe avrabe commented Feb 8, 2026

Summary

This PR addresses three related issues to improve reliability, documentation, and test coverage.

Issue #14 - Fix OCI Composition Dependency Ordering

Problem: The oci_publish_deps attribute in wac_compose_with_oci was declared but not implemented, causing race conditions where OCI pull could execute before publish completed.

Fix:

  • Collect output files from oci_publish_deps targets
  • Add them to the OCI pull action's inputs parameter
  • Bazel's action graph now enforces correct ordering
# Now works correctly:
wac_compose_with_oci(
    name = "app",
    oci_components = {"service": "localhost:5001/my/service:v1"},
    oci_publish_deps = [":publish_service"],  # Enforced!
)

Issue #18 - RBE Documentation

Status: Added detailed comments explaining why local: "1" is needed and the path to RBE support.

Issue #34 - WRPC Testing Infrastructure

Added: Complete test infrastructure following Bazel 2026 best practices.

test/wrpc/
├── BUILD.bazel          # 30+ test targets
├── fixtures/
│   └── calculator.wit   # Test WIT interface
└── wrpc_tests.bzl       # Analysis test rules

Tests include:

  • transport_provider_test: Validates WrpcTransportInfo fields
  • wrpc_bindgen_test: Validates binding generation output
  • build_test: Smoke tests for all transport and bindgen rules

Test plan

  • bazel build //wkg:defs //go:defs //js:defs - bzl files load correctly
  • bazel build //test/wrpc:transport_build_test - transport tests build
  • Full CI validation

Fixes #14
Relates to #18
Fixes #34

🤖 Generated with Claude Code

…d WRPC tests

Issue #14 - Fix OCI composition dependency ordering:
- Collect outputs from oci_publish_deps targets in wac_compose_with_oci
- Add publish_dep_files to OCI pull action inputs
- This enforces Bazel graph-level ordering: publish completes before pull

Issue #18 - Improve RBE documentation and compatibility:
- Add detailed RBE status comments to TinyGo execution_requirements
- Add detailed RBE status comments to NPM install execution_requirements
- Document why local execution is needed and future path to RBE support
- Reference Issue #18 for tracking full RBE enablement

Issue #34 - Add WRPC testing infrastructure:
- Create test/wrpc/ directory with BUILD.bazel and analysis tests
- Add transport_provider_test for validating WrpcTransportInfo
- Add wrpc_bindgen_test for validating binding generation
- Add fixtures/calculator.wit as test WIT interface
- Add build_test smoke tests for transport and bindgen rules
- Following Bazel 2026 best practices (analysistest, build_test)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WRPC implementation lacks testing and validation Fix OCI composition dependency ordering in simple_oci_test

1 participant