fix: OCI ordering, RBE docs, and WRPC tests (#14, #18, #34)#344
Open
fix: OCI ordering, RBE docs, and WRPC tests (#14, #18, #34)#344
Conversation
…d WRPC tests Issue #14 - Fix OCI composition dependency ordering: - Collect outputs from oci_publish_deps targets in wac_compose_with_oci - Add publish_dep_files to OCI pull action inputs - This enforces Bazel graph-level ordering: publish completes before pull Issue #18 - Improve RBE documentation and compatibility: - Add detailed RBE status comments to TinyGo execution_requirements - Add detailed RBE status comments to NPM install execution_requirements - Document why local execution is needed and future path to RBE support - Reference Issue #18 for tracking full RBE enablement Issue #34 - Add WRPC testing infrastructure: - Create test/wrpc/ directory with BUILD.bazel and analysis tests - Add transport_provider_test for validating WrpcTransportInfo - Add wrpc_bindgen_test for validating binding generation - Add fixtures/calculator.wit as test WIT interface - Add build_test smoke tests for transport and bindgen rules - Following Bazel 2026 best practices (analysistest, build_test) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses three related issues to improve reliability, documentation, and test coverage.
Issue #14 - Fix OCI Composition Dependency Ordering
Problem: The
oci_publish_depsattribute inwac_compose_with_ociwas declared but not implemented, causing race conditions where OCI pull could execute before publish completed.Fix:
oci_publish_depstargetsinputsparameterIssue #18 - RBE Documentation
Status: Added detailed comments explaining why
local: "1"is needed and the path to RBE support.Issue #34 - WRPC Testing Infrastructure
Added: Complete test infrastructure following Bazel 2026 best practices.
Tests include:
transport_provider_test: Validates WrpcTransportInfo fieldswrpc_bindgen_test: Validates binding generation outputbuild_test: Smoke tests for all transport and bindgen rulesTest plan
bazel build //wkg:defs //go:defs //js:defs- bzl files load correctlybazel build //test/wrpc:transport_build_test- transport tests buildFixes #14
Relates to #18
Fixes #34
🤖 Generated with Claude Code