feat: salsa integration (Phase 5) + dogfood tracking#121
Merged
Conversation
13 features: rowan Phases 1-3, 6 domain schemas, MCP expansion, schema validate, docs refresh, pre-commit hook. 573 total artifacts.
parse_artifacts_v2() tracked function uses extract_schema_driven() from the rowan HIR layer. Schema is a transitive salsa dependency — schema changes invalidate all artifact extraction, source changes only re-extract that file. Feature flag 'rowan-yaml' (default on). Debug builds log warnings if old and new parsers produce different artifact IDs. build_store() now takes schema_set parameter for the new code path. All 7 db.store() call sites updated.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 4e1288e | Previous: e4f398e | Ratio |
|---|---|---|---|
store_insert/10000 |
13594684 ns/iter (± 1302277) |
10627147 ns/iter (± 124724) |
1.28 |
traceability_matrix/1000 |
61433 ns/iter (± 2404) |
47654 ns/iter (± 150) |
1.29 |
query/10000 |
135573 ns/iter (± 1158) |
90301 ns/iter (± 409) |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5 rowan→salsa + FEAT-093 to FEAT-105 (573 artifacts). Refs #22.
🤖 Generated with Claude Code