Skip to content

Fixed logo-url on genearted openapi spec#7406

Merged
pedro-psb merged 1 commit intopulp:mainfrom
pedro-psb:fix-restapi-logo-url
Mar 6, 2026
Merged

Fixed logo-url on genearted openapi spec#7406
pedro-psb merged 1 commit intopulp:mainfrom
pedro-psb:fix-restapi-logo-url

Conversation

@pedro-psb
Copy link
Member

@pedro-psb pedro-psb commented Mar 6, 2026

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

jobselko
jobselko previously approved these changes Mar 6, 2026
Copy link
Contributor

@jobselko jobselko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should backport this to 3.104, 3.85 and 3.49 (is this worth changelog?)

@pedro-psb pedro-psb force-pushed the fix-restapi-logo-url branch from 9d9dc53 to dfcc9da Compare March 6, 2026 19:09
@pedro-psb pedro-psb enabled auto-merge (rebase) March 6, 2026 19:56
@pedro-psb pedro-psb merged commit 0128e58 into pulp:main Mar 6, 2026
13 checks passed
@patchback
Copy link

patchback bot commented Mar 6, 2026

Backport to 3.49: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.49/0128e58bf427a6b61c0a1f4017cb22dfe4612563/pr-7406

Backported as #7412

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Mar 6, 2026

Backport to 3.63: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 0128e58 on top of patchback/backports/3.63/0128e58bf427a6b61c0a1f4017cb22dfe4612563/pr-7406

Backporting merged PR #7406 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/pulp/pulpcore.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.63/0128e58bf427a6b61c0a1f4017cb22dfe4612563/pr-7406 upstream/3.63
  4. Now, cherry-pick PR Fixed logo-url on genearted openapi spec #7406 contents into that branch:
    $ git cherry-pick -x 0128e58bf427a6b61c0a1f4017cb22dfe4612563
    If it'll yell at you with something like fatal: Commit 0128e58bf427a6b61c0a1f4017cb22dfe4612563 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 0128e58bf427a6b61c0a1f4017cb22dfe4612563
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fixed logo-url on genearted openapi spec #7406 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.63/0128e58bf427a6b61c0a1f4017cb22dfe4612563/pr-7406
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Mar 6, 2026

Backport to 3.73: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 0128e58 on top of patchback/backports/3.73/0128e58bf427a6b61c0a1f4017cb22dfe4612563/pr-7406

Backporting merged PR #7406 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/pulp/pulpcore.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.73/0128e58bf427a6b61c0a1f4017cb22dfe4612563/pr-7406 upstream/3.73
  4. Now, cherry-pick PR Fixed logo-url on genearted openapi spec #7406 contents into that branch:
    $ git cherry-pick -x 0128e58bf427a6b61c0a1f4017cb22dfe4612563
    If it'll yell at you with something like fatal: Commit 0128e58bf427a6b61c0a1f4017cb22dfe4612563 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 0128e58bf427a6b61c0a1f4017cb22dfe4612563
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fixed logo-url on genearted openapi spec #7406 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.73/0128e58bf427a6b61c0a1f4017cb22dfe4612563/pr-7406
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Mar 6, 2026

Backport to 3.85: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.85/0128e58bf427a6b61c0a1f4017cb22dfe4612563/pr-7406

Backported as #7413

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Mar 6, 2026

Backport to 3.104: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.104/0128e58bf427a6b61c0a1f4017cb22dfe4612563/pr-7406

Backported as #7414

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants