Skip to content

Fix ALLOWED_CONTENT_CHECKSUMS check failing on settings import#7400

Merged
gerrod3 merged 1 commit intopulp:mainfrom
gerrod3:checksum-check
Mar 6, 2026
Merged

Fix ALLOWED_CONTENT_CHECKSUMS check failing on settings import#7400
gerrod3 merged 1 commit intopulp:mainfrom
gerrod3:checksum-check

Conversation

@gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Mar 5, 2026

Moved the check to separate Django check ran after database commands. Loosen the restrictions on Forbidden Checksums being present to just a warning.

fixes: #7380
Generated by: claude-opus-4.6

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

Moved the check to separate Django check ran after database commands.
Loosen the restrictions on Forbidden Checksums being present to just a warning.

fixes: pulp#7380
Generated by: claude-opus-4.6
@gerrod3 gerrod3 merged commit 1e4afec into pulp:main Mar 6, 2026
13 checks passed
@gerrod3 gerrod3 deleted the checksum-check branch March 6, 2026 15:51
@patchback
Copy link

patchback bot commented Mar 6, 2026

Backport to 3.28: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 1e4afec on top of patchback/backports/3.28/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400

Backporting merged PR #7400 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/pulp/pulpcore.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.28/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400 upstream/3.28
  4. Now, cherry-pick PR Fix ALLOWED_CONTENT_CHECKSUMS check failing on settings import #7400 contents into that branch:
    $ git cherry-pick -x 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43
    If it'll yell at you with something like fatal: Commit 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix ALLOWED_CONTENT_CHECKSUMS check failing on settings import #7400 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.28/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Mar 6, 2026

Backport to 3.63: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 1e4afec on top of patchback/backports/3.63/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400

Backporting merged PR #7400 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/pulp/pulpcore.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.63/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400 upstream/3.63
  4. Now, cherry-pick PR Fix ALLOWED_CONTENT_CHECKSUMS check failing on settings import #7400 contents into that branch:
    $ git cherry-pick -x 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43
    If it'll yell at you with something like fatal: Commit 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix ALLOWED_CONTENT_CHECKSUMS check failing on settings import #7400 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.63/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Mar 6, 2026

Backport to 3.73: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 1e4afec on top of patchback/backports/3.73/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400

Backporting merged PR #7400 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/pulp/pulpcore.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.73/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400 upstream/3.73
  4. Now, cherry-pick PR Fix ALLOWED_CONTENT_CHECKSUMS check failing on settings import #7400 contents into that branch:
    $ git cherry-pick -x 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43
    If it'll yell at you with something like fatal: Commit 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix ALLOWED_CONTENT_CHECKSUMS check failing on settings import #7400 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.73/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Mar 6, 2026

Backport to 3.49: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 1e4afec on top of patchback/backports/3.49/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400

Backporting merged PR #7400 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/pulp/pulpcore.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.49/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400 upstream/3.49
  4. Now, cherry-pick PR Fix ALLOWED_CONTENT_CHECKSUMS check failing on settings import #7400 contents into that branch:
    $ git cherry-pick -x 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43
    If it'll yell at you with something like fatal: Commit 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 1e4afec5de06b4b7667107d6b6ec4c96c3e01e43
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix ALLOWED_CONTENT_CHECKSUMS check failing on settings import #7400 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.49/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Mar 6, 2026

Backport to 3.85: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.85/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400

Backported as #7408

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Mar 6, 2026

Backport to 3.104: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.104/1e4afec5de06b4b7667107d6b6ec4c96c3e01e43/pr-7400

Backported as #7407

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive ImproperlyConfigured on startup: forbidden checksum check ignores user's ALLOWED_CONTENT_CHECKSUMS override

2 participants