Fix content app directory listing links with colons in base_path#7393
Draft
Fix content app directory listing links with colons in base_path#7393
Conversation
closes pulp#6955 Assisted-by: Claude (Cursor) Made-with: Cursor
gerrod3
force-pushed
the
fix/6955-colon-in-base-path-links
branch
from
0a21ea1 to
e753f40
Compare
Contributor
Author
|
I wonder if changing to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_pathcontains colons (e.g.copr-pull-requests:pr:3825/)../to thehrefensures the link is always treated as a relative path.Test plan
render_htmlwith and without colons in directory names.closes #6955
Made with Cursor