Skip to content

Fix syncing with non-https URL #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jobselko merged 1 commit into from
Mar 10, 2026
+2 −2
Merged

Fix syncing with non-https URL #1136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/+non-https-syncs.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed sync issue where non https URLs were not allowed.
3 changes: 1 addition & 2 deletions pulp_python/app/tasks/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ def create_bandersnatch_config(remote):
config = BandersnatchConfig()
config["mirror"]["master"] = remote.url
config["mirror"]["workers"] = str(remote.download_concurrency)
config["mirror"]["allow_non_https"] = "true"
if not config.has_section("plugins"):
config.add_section("plugins")
config["plugins"]["enabled"] = "blocklist_release\n"
Expand Down Expand Up @@ -120,7 +119,7 @@ async def run(self):
if not isinstance(downloader, HttpDownloader):
raise ValueError("Only HTTP(S) is supported for python syncing")

async with Master(url) as master:
async with Master(url, allow_non_https=True) as master:
# Replace the session with the remote's downloader session
old_session = master.session
master.session = downloader.session
Expand Down