fix: correctly resolve npm dist-tags latest using semver - #415
Open
BethGriggs wants to merge 1 commit into
Open
Conversation
Previously, latest was selected using Python's built-in max() on raw version strings, which performs lexicographic comparison (e.g. "9.0.0" > "10.0.0") and did not exclude pre-release versions. - Parse all version strings once via semver.Version.parse, skipping any malformed values, to avoid redundant parsing and ValueError on invalid versions in the fallback path - Filter out pre-release versions (e.g. 1.0.0-alpha.1) when selecting the latest dist-tag; fall back to all valid semver versions if no stable versions exist - Add semver>=3.0.0 as a declared runtime dependency in pyproject.toml - Fix extract_package_info() regex to match full semver strings including pre-release and build-metadata suffixes; make base_name non-greedy ([^/]+?) to avoid ambiguity on hyphenated package names like my-pkg-1.0.0-rc.1.tgz, where a greedy match would consume into the version and cause extract_package_info() to return (None, None) Assisted By: Bob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, latest was selected using Python's built-in
max()on raw version strings, which performs lexicographic comparison (e.g. "9.0.0" > "10.0.0") and did not exclude pre-release versions.max(versions)withsemver.Version.parseas sort key so that 10.0.0 correctly ranks above 9.0.01.0.0-alpha.1) when selecting thelatestdist-tag; fall back to all versions only if no stable versions existsemver>=3.0.0as a declared runtime dependency inpyproject.tomlextract_package_info()regex to match full semver strings including pre-release and build-metadata suffixes, and make the base_name group non-greedy to correctly split hyphenated package names from their version📜 Checklist