Skip to content

[ru] fix Spy x Family chapter number#455

Merged
curche merged 1 commit intopubloader:mainfrom
valdotle:fix-chapter-number
Apr 5, 2026
Merged

[ru] fix Spy x Family chapter number#455
curche merged 1 commit intopubloader:mainfrom
valdotle:fix-chapter-number

Conversation

@valdotle
Copy link
Copy Markdown
Contributor

@valdotle valdotle commented Apr 4, 2026

Someone reported this on MD where the bot uploaded it as 127.1
image discord msg

@curche
Copy link
Copy Markdown
Collaborator

curche commented Apr 5, 2026

LGTM, merging this for now.

Seems like all chapters of russian are free to read so might need to check entire chapter list for a pattern like x, y.1, y.2, c, z

@curche curche merged commit 9aae2d9 into publoader:main Apr 5, 2026
2 checks passed
@valdotle valdotle deleted the fix-chapter-number branch April 6, 2026 00:14
@valdotle
Copy link
Copy Markdown
Contributor Author

valdotle commented Apr 7, 2026

LGTM, merging this for now.

Seems like all chapters of russian are free to read so might need to check entire chapter list for a pattern like x, y.1, y.2, c, z

I went back and checked, and it seems like this was the only problematic chapter. Probably because it's an extra illustration (so would expect .5) while also having a number in the chapter title, so the uploader picked it up as a partial chapter.
That being said, the decimals are a bit confusing (.2 .1 and .5 don't always seem to follow a clear rule) + I got caught off guard by chapters missing the volume number midway... 😅
I should have a look into having the volume number logic use unavailable chapter metadata as well some time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants