Add method to reorder steps in sequencer object

[rishabhshuklax]

Fixes #1621

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[codecov]

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.23%. Comparing base (853e719) to head (fa96a7a).
⚠️ Report is 387 commits behind head on main.

Files with missing lines	Patch %	Lines
src/ImageSequencer.js	11.11%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1626      +/-   ##
==========================================
- Coverage   66.67%   65.23%   -1.45%     
==========================================
  Files         130      132       +2     
  Lines        2686     2750      +64     
  Branches      433      439       +6     
==========================================
+ Hits         1791     1794       +3     
- Misses        895      956      +61     

Files with missing lines	Coverage Δ
src/ImageSequencer.js	48.25% <11.11%> (-2.06%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[harshkhandeparkar]

I think the old code has non-descriptive variables and is, well, old. Can we at least make the new additions better if not change the old code?

[rishabhshuklax]

I think the old code has non-descriptive variables and is, well, old. Can we at least make the new additions better if not change the old code?

I think we should make a seperate issue to change these names in a single PR as changing the names on the newer code will make it inconsistent.

[gitpod-io]

[harshkhandeparkar]

I meant this btw, can these be named something better?

[rishabhshuklax]

Are that's what I said in the file these names are used in the other functions as well so it'd be better to change it all together so as to avoid any inconsistency.

image-sequencer/src/ImageSequencer.js

Lines 127 to 131 in fa96a7a

	var args = [];
	for (var arg in arguments) args.push(copy(arguments[arg]));
	var json_q = formatInput.call(this_, args, '-');
	inputlog.push({ method: 'removeSteps', json_q: copy(json_q) });

[harshkhandeparkar]

So you basically don't know what they even mean? 😂

[harshkhandeparkar]

It's fine. APPROVED lol.

[jywarren]

Hey lets be nice here! I am probably guilty of the ambiguous naming after all :-) so I can take the blame.

I agree though that let's change it in a consistent manner so as not to confuse folks. And if there are any opportunities to reduce repetitive code, that's great too!

[harshkhandeparkar]

Oh sorry. I was just joking anyway, you are lucky that I didn't build sequencer's backend 😂

[jywarren]

This is a cool one! I'd like to request:

1. a good test demonstrating its use and guaranteeing it against future breakage
2. a line in the README describing the function and how to use it.

Thank you!!!! No rush, just looking for what we should start requiring for all changes moving forward!