Adopt template workflow conventions (release-asset, retention, docker-readme)#757
Merged
Merged
Conversation
…-readme) - build-executable-task.yml: upload the standalone build as release-asset-<branch>-executable and drop the artifact-id output, so the GitHub release collects assets by the release-asset-<branch>-* pattern instead of naming the build job (#727). - build-release-task.yml: the github-release job now downloads release-asset-<branch>-* with merge-multiple, never referencing a build job. - Set retention-days: 1 on the intermediate upload-artifact steps (build-executable-task per-runtime + final, build-toolversions) so they do not pile up against the artifact-storage quota (#745). - Rename build-dockerreadme-task.yml to publish-docker-readme-task.yml and align the task/job names (entry-point/orchestrator naming); keep the m4 tool-version render and the working DOCKER_HUB_USERNAME/PASSWORD auth. - Update the AGENTS.md and ARCHITECTURE.md references to the renamed task. Closes #727. Closes #745. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR reconverges PlexCleaner’s GitHub Actions workflows with the current ptr727/ProjectTemplate conventions, focusing on the release-asset artifact seam, artifact-retention tuning, and the Docker Hub README publisher task rename.
Changes:
- Switch GitHub release assembly to the
release-asset-<branch>-*artifact pattern (removing the prior per-jobartifact-idwiring). - Add
retention-days: 1to intermediate workflow artifacts to reduce long-lived artifact storage accumulation. - Rename and rewire the Docker Hub README reusable workflow to
publish-docker-readme-task.yml, updating references accordingly.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
ARCHITECTURE.md |
Updates the workflow/task inventory to reflect the Docker README task rename. |
AGENTS.md |
Updates documentation references to the renamed Docker README task and reflects the release-asset seam wording. |
.github/workflows/publish-release.yml |
Points the release publisher to the renamed Docker README reusable workflow and updates the job name. |
.github/workflows/publish-docker-readme-task.yml |
Renames the reusable workflow and job labels to match the template naming conventions. |
.github/workflows/build-toolversions-task.yml |
Adds retention-days: 1 to uploaded versions artifacts and updates the consumer reference comment. |
.github/workflows/build-release-task.yml |
Downloads release assets via pattern: release-asset-<branch>-* + merge-multiple instead of artifact-ids. |
.github/workflows/build-executable-task.yml |
Removes the reusable-workflow artifact-id output, uploads the executable as release-asset-<branch>-executable, and sets artifact retention to 1 day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow portion of the template reconverge (follows #756, the docs portion). Aligns the GitHub Actions workflows with the current ptr727/ProjectTemplate conventions.
Changes
build-executable-task.ymlnow uploads the standalone build asrelease-asset-<branch>-executableand drops theartifact-idworkflow output;build-release-task.yml'sgithub-releasejob collects assets viapattern: release-asset-<branch>-*+merge-multipleinstead of naming the build job. Same files land on the release; the orchestration stays reusable verbatim as targets change.retention-days: 1on the intermediateupload-artifactsteps (the per-runtimepublish-<branch>-<runtime>, the executable release asset, andversions-<branch>) so they no longer accrue against the 90-day account quota.build-dockerreadme-task.yml->publish-docker-readme-task.ymland aligned the task/job names; kept PlexCleaner's m4 tool-version render and the workingDOCKER_HUB_USERNAME/DOCKER_HUB_PASSWORDauth (the description-update endpoint needs aread/write/deletecredential; the account password works, so it's retained rather than switched to a push-scoped token).AGENTS.md/ARCHITECTURE.mdreferences to the renamed task.Validation
Workflow-only changes are intentionally not path-filtered into PR smoke builds, so this is validated with
actionlintlocally (clean on all changed files) and a manualworkflow_dispatchpublish after merge (which exercisesbuild-executable-task->release-asset-*collection and the renamed docker-readme task end-to-end).Closes #727. Closes #745.
🤖 Generated with Claude Code