Skip to content

Adopt template workflow conventions (release-asset, retention, docker-readme)#757

Merged
ptr727 merged 1 commit into
developfrom
chore/template-resync-workflows
Jun 22, 2026
Merged

Adopt template workflow conventions (release-asset, retention, docker-readme)#757
ptr727 merged 1 commit into
developfrom
chore/template-resync-workflows

Conversation

@ptr727

@ptr727 ptr727 commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Workflow portion of the template reconverge (follows #756, the docs portion). Aligns the GitHub Actions workflows with the current ptr727/ProjectTemplate conventions.

Changes

  • Release-asset seam (Re-converge release workflows: collect GitHub-release assets via release-asset-<branch>-* convention #727): build-executable-task.yml now uploads the standalone build as release-asset-<branch>-executable and drops the artifact-id workflow output; build-release-task.yml's github-release job collects assets via pattern: release-asset-<branch>-* + merge-multiple instead of naming the build job. Same files land on the release; the orchestration stays reusable verbatim as targets change.
  • Artifact retention (Re-sync from template #167: docs/comment cleanup, CI storage limits, new tasks #745): retention-days: 1 on the intermediate upload-artifact steps (the per-runtime publish-<branch>-<runtime>, the executable release asset, and versions-<branch>) so they no longer accrue against the 90-day account quota.
  • Docker Hub readme: renamed build-dockerreadme-task.yml -> publish-docker-readme-task.yml and aligned the task/job names; kept PlexCleaner's m4 tool-version render and the working DOCKER_HUB_USERNAME / DOCKER_HUB_PASSWORD auth (the description-update endpoint needs a read/write/delete credential; the account password works, so it's retained rather than switched to a push-scoped token).
  • Updated the AGENTS.md / ARCHITECTURE.md references to the renamed task.

Validation

Workflow-only changes are intentionally not path-filtered into PR smoke builds, so this is validated with actionlint locally (clean on all changed files) and a manual workflow_dispatch publish after merge (which exercises build-executable-task -> release-asset-* collection and the renamed docker-readme task end-to-end).

Closes #727. Closes #745.

🤖 Generated with Claude Code

…-readme)

- build-executable-task.yml: upload the standalone build as
  release-asset-<branch>-executable and drop the artifact-id output, so the
  GitHub release collects assets by the release-asset-<branch>-* pattern
  instead of naming the build job (#727).
- build-release-task.yml: the github-release job now downloads
  release-asset-<branch>-* with merge-multiple, never referencing a build job.
- Set retention-days: 1 on the intermediate upload-artifact steps
  (build-executable-task per-runtime + final, build-toolversions) so they
  do not pile up against the artifact-storage quota (#745).
- Rename build-dockerreadme-task.yml to publish-docker-readme-task.yml and
  align the task/job names (entry-point/orchestrator naming); keep the m4
  tool-version render and the working DOCKER_HUB_USERNAME/PASSWORD auth.
- Update the AGENTS.md and ARCHITECTURE.md references to the renamed task.

Closes #727. Closes #745.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 22, 2026 19:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reconverges PlexCleaner’s GitHub Actions workflows with the current ptr727/ProjectTemplate conventions, focusing on the release-asset artifact seam, artifact-retention tuning, and the Docker Hub README publisher task rename.

Changes:

  • Switch GitHub release assembly to the release-asset-<branch>-* artifact pattern (removing the prior per-job artifact-id wiring).
  • Add retention-days: 1 to intermediate workflow artifacts to reduce long-lived artifact storage accumulation.
  • Rename and rewire the Docker Hub README reusable workflow to publish-docker-readme-task.yml, updating references accordingly.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ARCHITECTURE.md Updates the workflow/task inventory to reflect the Docker README task rename.
AGENTS.md Updates documentation references to the renamed Docker README task and reflects the release-asset seam wording.
.github/workflows/publish-release.yml Points the release publisher to the renamed Docker README reusable workflow and updates the job name.
.github/workflows/publish-docker-readme-task.yml Renames the reusable workflow and job labels to match the template naming conventions.
.github/workflows/build-toolversions-task.yml Adds retention-days: 1 to uploaded versions artifacts and updates the consumer reference comment.
.github/workflows/build-release-task.yml Downloads release assets via pattern: release-asset-<branch>-* + merge-multiple instead of artifact-ids.
.github/workflows/build-executable-task.yml Removes the reusable-workflow artifact-id output, uploads the executable as release-asset-<branch>-executable, and sets artifact retention to 1 day.

@ptr727 ptr727 merged commit b1a7ff8 into develop Jun 22, 2026
6 checks passed
@ptr727 ptr727 deleted the chore/template-resync-workflows branch June 22, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants