Skip to content

Replace test #pragma suppressions with SuppressMessage and null-forgiving #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 2 commits into from
Jun 22, 2026
Merged

Replace test #pragma suppressions with SuppressMessage and null-forgiving #184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5543e3
Replace test #pragma suppressions with SuppressMessage and null-forgi…
ptr727 Jun 22, 2026
3cb1785
Document why null-forgiving is needed on the Equals(object?) receiver
ptr727 Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions LanguageTagsTests/LanguageTagTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,8 @@ public void Equals_NullTag_ReturnsFalse()
{
LanguageTag tag = LanguageTag.Parse("en-US")!;
_ = tag.Equals(null).Should().BeFalse();
#pragma warning disable CS8602
_ = tag.Equals((object?)null).Should().BeFalse();
#pragma warning restore CS8602
// tag is non-null; ! avoids a CS8602 false-positive on the Equals(object?) receiver.
_ = tag!.Equals((object?)null).Should().BeFalse();
Comment thread
ptr727 marked this conversation as resolved.
}

[Fact]
Expand Down Expand Up @@ -282,14 +281,17 @@ public void OperatorEquals_DifferentTags_ReturnsFalse()
}

[Fact]
[System.Diagnostics.CodeAnalysis.SuppressMessage(
"Maintainability",
"CA1508:Avoid dead conditional code",
Justification = "Test intentionally compares two null tags to exercise operator== with both operands null."
)]
public void OperatorEquals_BothNull_ReturnsTrue()
{
LanguageTag? tag1 = null;
LanguageTag? tag2 = null;

#pragma warning disable CA1508 // Avoid dead conditional code
_ = (tag1 == tag2).Should().BeTrue();
#pragma warning restore CA1508
}

[Fact]
Expand Down